search

openmrslab / suspect

MRS processing tools
https://suspect.readthedocs.io/en/latest/
MIT License
31 stars 23 forks source link

ENH: Correction of eddy current effects #127

Open 0rC0 opened 4 years ago

0rC0 commented 4 years ago

Is it possible somehow to make some eddy current correction?

If not yet, it can be a nice enhancement. It is also in the experts' consensus recommendations in:

Near, Jamie & Harris, Ashley & Juchem, Christoph & Kreis, Roland & Marjańska, Małgorzata & Öz, Gülin & Slotboom, Johannes & Wilson, Martin & Gasparovic, Charles. (2020). Preprocessing, analysis and quantification in single-voxel magnetic resonance spectroscopy: experts' consensus recommendations. NMR in Biomedicine. e4257. 10.1002/nbm.4257.

bennyrowland commented 4 years ago

Eddy current correction as proposed in the consensus paper is so simple that it just takes a couple of lines of standard numpy code, so personally I feel that it doesn't make sense putting it in the library. However, I do agree that this would be an excellent subject for the documentation tutorial series. I will see if I can draft something this week.

bkossows commented 2 years ago

Ben, would You mind sharing those lines for numpy?

bennyrowland commented 2 years ago

@bkossows sorry for the delay in response. I have just uploaded a new page in the documentation: https://suspect.readthedocs.io/en/latest/notebooks/consensus_playground.html that goes over the complete experts' consensus pipeline, including ECC. Check it out and let me know if it answers your questions.