openmsr / CAD_to_OpenMC

code to target the conversion from a step-file to a h5m-geometry for neutronics
MIT License
29 stars 18 forks source link

Sometimes the heal_stl function can bork - with the gmsh-backend #46

Closed ebknudsen closed 1 year ago

ebknudsen commented 1 year ago

It happens that no stl -attribute is set when looping through the enities in the in the hea_stl function

ebknudsen commented 1 year ago

This seems to be caused by the stl-attribute of Entity not being reported back to Assembly from the mesher class correctly. We should find better/more stable way of doing this. At present the entities-list is stored as a class attribute for the stl-backend, whereas it is a standard object attribute in the gmsh-backend.

ebknudsen commented 1 year ago

suppose we were to add the stl-field in the Entity-constructor, instead of on the fly.

ebknudsen commented 1 year ago

This is now fixed in the cq/stl-backend. The casuse turned out to be that the entities-list was not reset when reusing the mesher-backend.