Simplify Gmsh brep import

openmsr / CAD_to_OpenMC

code to target the conversion from a step-file to a h5m-geometry for neutronics

MIT License

25 stars 16 forks source link

Simplify Gmsh brep import #59

Open akoen opened 10 months ago

akoen commented 10 months ago

OCC objects can be directly imported into Gmsh using a native pointer instead of exporting and importing a brep file.

https://github.com/openmsr/CAD_to_OpenMC/blob/18a138f0bf23d02ce95d48f79961f923031acd33/src/CAD_to_OpenMC/assemblymesher_gmsh.py#L92C21-L92C21

See Cad-to-DAGMC: https://github.com/fusion-energy/cad_to_dagmc/blob/bf0243cb4f8de46d0958760a12b83610dedffdc5/src/cad_to_dagmc/brep_to_h5m.py#L32C6-L32C6

ebknudsen commented 9 months ago

Thanks for the comment - this is scheduled to happen in the overnext release.

ebknudsen commented 8 months ago

This fix will have to be postponed as originally intended as I can't seem to get it to work reliably right now. Reverting 37aa015de657f014e68e2481a447917f1f51463b for now.