openmsr / CAD_to_OpenMC

code to target the conversion from a step-file to a h5m-geometry for neutronics
MIT License
29 stars 18 forks source link

Missing faces in some objects of large models. #87

Closed ebknudsen closed 10 months ago

ebknudsen commented 11 months ago

At times, as is the case for the MSBR-model, we find that some faces may be missing from some objects, causing the model to be leaky.

ebknudsen commented 11 months ago

This seems (at least in cases) to be caused by hash code collisions in the surface hash-table

ebknudsen commented 10 months ago

this was fixed by #88 - closing

ebknudsen commented 10 months ago

the hash-code-collisions were caused by the fact that the position of the object was not contributing to the hash-code meaning that for large models it would be likely to have collisions