openmultiplayer / omp-stdlib

Pawn includes
Mozilla Public License 2.0
42 stars 16 forks source link

Complete issues. #33

Open shierru opened 10 months ago

shierru commented 10 months ago

Complete issues

Details

The GetPlayerAnimationFlags function is a duplicate of the GetPlayerAnimFlags function and I'm thinking about whether it should be labelled as such:

native GetPlayerAnimationFlags(playerid) = GetPlayerAnimFlags;

Or should it not be done?

It's not done at the moment.

Additionally:

shierru commented 10 months ago

I changed the parameter name of the function: native bool:TogglePlayerWidescreen(playerid, bool:wide) => native bool:TogglePlayerWidescreen(playerid, bool:enable)

Since the feature was added quite recently, I doubt that it will cause any serious problems for users.

Y-Less commented 9 months ago

Changing parameter names in natives doesn't make any difference. Annoyingly it does in forward for some weird reason, but that doesn't apply here and it just a side note.

I also wondering if GetPlayerAnimationFlags should return a tag/enum of valid values.

adib-yg commented 9 months ago

There's a doc for GetPlayerAnimationFlags Can these definitions be added to stdlib?

#define ANIM_FREEZE_FLAG   0b0000000000000100
#define ANIM_LOCK_X_FLAG   0b0010000000000
#define ANIM_LOCK_Y_FLAG   0b0001000000000
#define ANIM_LOOP_FLAG     0b0000100000000
Y-Less commented 9 months ago

Probably just use hex like most other numbers, but otherwise yes that's what I meant by the enum comment.

shierru commented 7 months ago

I added a return tag for GetPlayerAnimationFlags. But I'm still not sure if I did it correctly.