Open shierru opened 10 months ago
I changed the parameter name of the function:
native bool:TogglePlayerWidescreen(playerid, bool:wide)
=> native bool:TogglePlayerWidescreen(playerid, bool:enable)
Since the feature was added quite recently, I doubt that it will cause any serious problems for users.
Changing parameter names in natives doesn't make any difference. Annoyingly it does in forward
for some weird reason, but that doesn't apply here and it just a side note.
I also wondering if GetPlayerAnimationFlags
should return a tag/enum of valid values.
There's a doc for GetPlayerAnimationFlags Can these definitions be added to stdlib?
#define ANIM_FREEZE_FLAG 0b0000000000000100
#define ANIM_LOCK_X_FLAG 0b0010000000000
#define ANIM_LOCK_Y_FLAG 0b0001000000000
#define ANIM_LOOP_FLAG 0b0000100000000
Probably just use hex like most other numbers, but otherwise yes that's what I meant by the enum comment.
I added a return tag for GetPlayerAnimationFlags
. But I'm still not sure if I did it correctly.
Complete issues
31.
32.
34
Details
The
GetPlayerAnimationFlags
function is a duplicate of theGetPlayerAnimFlags
function and I'm thinking about whether it should be labelled as such:Or should it not be done?
It's not done at the moment.
Additionally: