openmultiplayer / open.mp

Open Multiplayer, a multiplayer mod fully backwards compatible with SA-MP
https://open.mp
Mozilla Public License 2.0
424 stars 78 forks source link

Boundary between objects on the client (tested) #896

Closed Locky0 closed 3 months ago

Locky0 commented 3 months ago

I ran several tests, completely removing the limitation and using 037, and making this change that worked well on both the 037 and 03DL. I also did tests on vehicles, which I was unsuccessful at, but I preferred to keep the objects.

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

NexiusTailer commented 3 months ago

So you've got the object limit (2k) from 0.3.DL playing on 0.3.7 client version, right? This may be just because you tested it on R3-R5, while on R1-R2 it won't work and the limit will be 1k like 0.3.7 spec says.

ksenonadv commented 3 months ago

This obvs won't work at all, server will attempt to use slots > 1000; client won't be able to create those objects.

Locky0 commented 3 months ago

I carried out tests, in 037 it creates 999 objects. in 03DL there is more than that.

Locky0 commented 3 months ago

but using a streamer that directly uses the playerobject, with more than 60k objects. If the condition that I was able to perform is not there, client 037 would crash when passing the object limit.

Locky0 commented 3 months ago

Então você tem o limite de objetos (2k) do 0.3.DL reproduzido na versão do cliente 0.3.7, certo? Isso pode ser apenas porque você testou no R3-R5, enquanto no R1-R2 não funcionará e o limite será de 1k, como diz a especificação 0.3.7.

limit of all versions 0.3.7 is 1000 objects.

AmyrAhmady commented 3 months ago

This PR is not valid Only 0.3DL allows 2k objects. If we remove 1k limit, it wouldn't work for 1k extra objects in 0.3.7, players won't see extra objects and may crash, while server thinks it's good to create from 1000 to 2000, which is problematic, basically means dropping support

Closing it.