search

openmultiplayer / web

The open.mp web services monorepo. Homepage, documentation, server index, and more! All in one place.
https://open.mp/
108 stars 354 forks source link

Translate main pages #984

Open ulasbayraktar opened 5 months ago

adib-yg commented 5 months ago

I come to the conclusion that this is not good.

  1. The keys are very long. Isn't this better?
"Index": {
  "Getting Started": "Getting started",
  "Fully backwards compatible with existing scripts and clients": "Fully backwards compatible with existing scripts and clients",

  "index-text-1": "Getting started",
  "index-text-2": "Fully backwards compatible with existing scripts and clients",

Or like this: https://github.com/openmultiplayer/launcher/blob/master/src/locales/translations/en.ts

  1. Announcements are temporary and old announcement remain in files after replacement. It will be difficult to remove them in the future.

But please don't make any changes for now, let other team members decide.

AmyrAhmady commented 5 months ago

I'm not entirely sure how I feel about introducing a new way for translations while docs use directory based files I also know that doing the same as docs for regular pages probably isn't doable, so there's that.

@Southclaws what are your thoughts on this?

ulasbayraktar commented 5 months ago

Barnaby had already said that it should be like this @AmyrAhmady (key-value)