openmusic-project / openmusic

The OpenMusic visual programming / computer-aided composition environment
https://openmusic-project.github.io/openmusic/
GNU General Public License v3.0
319 stars 22 forks source link

portmidi: first note in measures (voice, poly) is silenced #49

Closed andersvi closed 1 year ago

andersvi commented 1 year ago

Seems the first note, at date=0, is silenced in these classes

Seems to be caused by time-signature midi-evt's being initialized to chan=0, then being sent to the port with chan=-1 (in #'portmidi-send-evt).

Not sure whats right? If they are set up with chan=1 (as the other default midi-evts), voices play ok.

But not poly's....

andersvi commented 1 year ago

Seems the original issue vs. the buggy timesignature is fixed.

And at least the import/export failures from yesterday.

Tell me when you've done the necessary testing, and i'll set up a pull-request from this branch

karimhaddad commented 1 year ago

ok! I am on it. First tests: with POLY objects using polymetrics and polytempi, jsut to be sure that complex objects play right and export without issues. Second tests: All platform, although this is just to be on the safe side :-)

Will keep you posted. Best K

karimhaddad commented 1 year ago

All tested passed OK! Tell me when can we merge.

THank you a lot!

BEst K

andersvi commented 1 year ago

Great! I've set up a pull-request from the 'fix_MIDI...'-branch.

karimhaddad commented 1 year ago

THanx Anders,

Merged!