search

openmusictheory / openmusictheory.github.io

A growing, online "textbook" for music theory and aural skills
340 stars 161 forks source link

Fix broken image links #48

Closed saketkc closed 7 years ago

saketkc commented 7 years ago

The current implementation of markdown image tags seems to be broken on many pages. For example, this page on Google Chrome(Linux x86/64 58.0.3029.140) looks like this:

pitches and octave designations open music theory

I am not sure if this is indeed the right way to fix things since a lot of other pages have the same issue.

saketkc commented 7 years ago

cc @kshaffer

kshaffer commented 7 years ago

Thanks for reporting this. It was an issue across the site, due to (it seems) a change in the way GitHub Pages treats markdown links. I made a wholesale update of the code, so this PR is no longer necessary. Thanks for helping out, though!

saketkc commented 7 years ago

No problem! Thanks for all your work, extremely useful! :-)