opennars / Narjure

A Clojure implementation of the Non-Axiomatic Reasoning System proposed by Pei Wang.
GNU General Public License v2.0
43 stars 11 forks source link

v2.0.1 main pull request. #68

Closed patham9 closed 8 years ago

patham9 commented 8 years ago

Still a lot to do, but I won't have time until end of december anymore, so I highly suggest releasing this as v2.0.1 if there are no big concerns, and we can add further improvements in the future for v2.0.2 and beyond anyway.

Please review!

TonyLo1 commented 8 years ago

I have run all the examples without a problem other than; Detective 2, fails to find solution (which you mentioned I believe). Also, the inference cycle time (fast) is set too fast and causes a backlog in the message queues. Reducing it to 20 was ok for me but I have a fast machine so may need checking on slower PC.

patham9 commented 8 years ago

Hm Detective2 seems to work for me: :outputanswer (["[:answer-to \"<{?who} --> murder>?\"] <{tom} --> murder>. %1.0;0.22697176653180676%" " "]) Yes "fast" is now really fast, but works on my i7 machine in most cases interestingly. But I will probably change the slow mode to "medium" as this one is also relatively fast now, and will add an additional "slow" mode.

patham9 commented 8 years ago

TonyLo1: If it's fine from your side, can you merge this pull request now? Also for me everything ran fine, but I don't want to merge my own pull request. :)