opennars / OpenNARS-for-Applications

General reasoning component for applications based on NARS theory.
https://cis.temple.edu/~pwang/NARS-Intro.html
MIT License
91 stars 40 forks source link

Safe iteration for temporal compounding #183

Closed patham9 closed 2 years ago

patham9 commented 2 years ago

Inducing temporal patterns should only select concepts which were existing at the cycle start and should make sure all of them are selected. (currently not always the case in master when new concepts are formed in the process)

patham9 commented 2 years ago

Done here: https://github.com/opennars/OpenNARS-for-Applications/pull/185 Not beautiful but that's what's necessary considering that we are looping over concept memory while manipulating it. It keeps track of whether new concepts are created while looping, and if so re-checks for concepts it wouldn't else iterate over if iteration order changed.

patham9 commented 2 years ago

solved https://github.com/opennars/OpenNARS-for-Applications/pull/182