The second argument's name in function Inference_EventUpdate declared in Inference.h and defined in Inference.c seems inconsistent, which is currentTime in .h and targetTime in .c.
Searching for other calls under Inference_EventUpdate, I found that the second argument passed in (such as here) is not necessarily "current time" but could be something else.
(Counterexample: Although Inference_GoalSequenceDeduction and Inference_RevisionAndChoice use name currentTime, all the called places are still passed currentTime)
For such cases, perhaps unifying it to targetTime will make the function signature and definition more consistent and will also reduce confusion for future readers?
The second argument's name in function
Inference_EventUpdatedeclared inInference.hand defined inInference.cseems inconsistent, which iscurrentTimein.handtargetTimein.c.Searching for other calls under Inference_EventUpdate, I found that the second argument passed in (such as here) is not necessarily "current time" but could be something else. (Counterexample: Although
Inference_GoalSequenceDeductionandInference_RevisionAndChoiceuse namecurrentTime, all the called places are still passedcurrentTime)For such cases, perhaps unifying it to
targetTimewill make the function signature and definition more consistent and will also reduce confusion for future readers?