richardli1598
commented
10 months ago Hello, I am a code review bot on flows.network. Here are my reviews of changed source code files in this PR.
The patch provided updates the eslint-plugin-react-refresh dependency from ^0.3.4 to ^0.4.0 in both package.json and package-lock.json. However, in package-lock.json, the actual updated version changes to 0.4.5, which is beyond the specified range of ^0.4.0.
Areas requiring changes:
- Inconsistency Between package.json and package-lock.json:
- In
package.json, the version is updated to^0.4.0, which means it accepts minor updates starting from0.4.0. - In
package-lock.json, the updated locked version is0.4.5, which might not be an issue sincenpm installgenerally updatespackage-lock.jsonwith the most recent compatible version respecting the semver range specified inpackage.json. However, if you intend to reflect a direct match in thepackage-lock.jsonas inpackage.json, this might be considered an unintentional discrepancy.
- In
If the goal is to keep version consistency across files, verify that you want to allow minor updates (which ^ permits) or if the specific 0.4.0 version is required for stability reasons. If the latter is the case, you should make sure package.json reflects this requirement accurately by specifying 0.4.0 without the caret ^ or by updating both files to match the exact same version you intend to lock to, such as 0.4.5.
- Peer Dependency in package-lock.json:
- It is noted that the
peerDependencieslist includeseslintwith>=7. Make sure the current version ofeslintused in the project satisfies this peer dependency requirement (current version is8.38.0, which satisfies this).
- It is noted that the
No other issues are visible within the context provided. Always ensure that after updating dependencies, you run any associated tests to verify that the update doesn't break functionality within the project. If there are no tests, consider whether it is appropriate to add some to safeguard against regressions introduced by dependency updates.
netlify[bot]
renovate[bot]
This PR contains the following updates:
^0.3.4->^0.4.0Release Notes
ArnaudBarre/eslint-plugin-react-refresh (eslint-plugin-react-refresh)
### [`v0.4.5`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#045) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.4...v0.4.5) - Allow `TaggedTemplateExpression` for styled components (fixes [#32](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/32)) ### [`v0.4.4`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#044) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.3...v0.4.4) - Add `allowExportNames` option (fixes [#29](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/29)) - Support memo default export function components (fixes [#27](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/27)) - Warn on export expressions that are not React component (array, object, logical expression, ...) (fixes [#26](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/26)) ### [`v0.4.3`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#043) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.2...v0.4.3) - Add warning for TS enums exports ### [`v0.4.2`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#042) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.1...v0.4.2) - Fix typos in messages ([#15](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/15), [#16](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/16)). Thanks [@adamschachne](https://togithub.com/adamschachne) & [@janikga](https://togithub.com/janikga)! ### [`v0.4.1`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#041) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.0...v0.4.1) - Ignore `export type *` (fixes [#12](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/12)) - Support for all-uppercase function wrapped in forwardRef/memo ([#11](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/11)) ### [`v0.4.0`](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#040) [Compare Source](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.3.5...v0.4.0) ##### Add `allowConstantExport` option (fixes [#8](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/8)) This option allow to don't warn when a constant (string, number, boolean, templateLiteral) is exported aside one or more components. This should be enabled if the fast refresh implementation correctly handles this case (HMR when the constant doesn't change, propagate update to importers when the constant changes). Vite supports it, PR welcome if you notice other integrations works well. ##### Allow all-uppercase function exports (fixes [#11](https://togithub.com/ArnaudBarre/eslint-plugin-react-refresh/issues/11)) This only works when using direct export. So this pattern doesn't warn anymore: ```jsx export const CMS = () => <>; ``` But this one will still warn: ```jsx const CMS = () => <>; export default CMS; ```Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.