search

opennem / openelectricity

Open Electricity
https://openelectricity.org.au
MIT License
8 stars 2 forks source link

eslint fails with 100+ errors #42

Open jamescrowley opened 2 months ago

jamescrowley commented 2 months ago

eslint has a tonne of errors currently (mostly, but not exclusively no-unused-vars). Prettier/format also needed to be run on a bunch of outlook.json files already committed to the repo (which may just make sense to be excluded from prettier?). Flagging this as I tripped over it with my work on #32.

Perhaps it would make sense to add a GitHub action that both runs the tests that will now be present, and also enforce linting/formatting?

chienleng commented 2 months ago

the current state of the front end needs a bit of a tidy up before adding GitHub action to enforce any linting and formatting. I will try and get some time hopefully in the next few months to do this.

though this shouldn't prevent writing the unit tests.