opennem / opennem-fe

An Open Platform for National Electricity Market Data
https://opennem.org.au
MIT License
62 stars 11 forks source link

Feature/add cc by #185

Closed chienleng closed 1 year ago

chienleng commented 1 year ago

Updates:

simonhac commented 1 year ago

@chienleng this workflow is new to me. is there a link to the branch release on this page? and how do i complete my review?

chienleng commented 1 year ago

if you want to review the design and see a preview, you should see this below the last comment.:

Screenshot 2023-06-09 at 5 58 23 pm

click on the Show Environments and click on 'View deployment' button should take you to the preview of this PR.

Screenshot 2023-06-09 at 5 58 29 pm

You can submit your review by going to the Files Changed tab, then click on 'Review Changes' and submit your review.

Screenshot 2023-06-09 at 6 03 47 pm Screenshot 2023-06-09 at 6 04 18 pm
chienleng commented 1 year ago

you could also look at each line change and add your comment if you are reviewing the code. I think for now let's start with the design. Just add your notes into the comments or suggestions. And approve via the 'Review changes' section if you are happy with it.

chienleng commented 1 year ago

I can walk you through the PR process next week. Now that we can easily deploy previews into cloudflare (thanks @nc9 and @gmmspi !) , you can test and review changes before we merge back to main branch.

simonhac commented 1 year ago

thank you for the great instructions @chienleng. much appreciated.

(not sure you need approval x 3!)

gmmspi commented 1 year ago

They get posted in #fe-builds in Slack too