Fixed issue #8 - Githubissues

8191 commented 10 years ago

Fixed line breaks in host comments to break bind zonefile syntax

jaydio commented 9 years ago

Hey Matt, can you please merge this one as well? I've bumped into this issue during initial deployment earlier this week and its annoying. Luckily I only had a few records out of 60 domains that were affected.

mattpascoe commented 9 years ago

Jay,

I had actually fixed this in my ipv6 branch as well. I replaced the new lines with spaces. I just havn't merged to master because I've not fully tested my ipv6 changes.

If possible do you think you could do a bit of testing of the ipv6 branch on your config? even if you dont have ipv6 I want to make sure that it does not break any existing ipv4 setups. I don't use Bind anymore so I don't have a proper test environment for it all currently.

If you can at least verify that the ipv6 branch is functional then I can merge it to master and this fix will be taken care of. Let me know if that works for you, if not I'll take care of the newlines for you.

Thanks again for your input on things!

On Wed, Oct 1, 2014 at 7:02 AM, JayD notifications@github.com wrote:

Hey Matt, can you please merge this one as well? I've bumped into this issue during initial deployment earlier this week and its annoying. Luckily I only had a few records out of 60 domains that were affected.

— Reply to this email directly or view it on GitHub https://github.com/opennetadmin/build_bind/pull/9#issuecomment-57459312.

mattpascoe commented 9 years ago

Not sure how my ipv6 branch might be impacted by the footer/config changes you just did.. I might need to dig in a bit more on that. Looks like it may be easier for me to just merge this change and move on. The one problem is the replacement needs to be just a space and not "; " because I've seen that create some issues with the config having the extra ; in it.

opennetadmin / build_bind

Fixed issue #8 #9