search

opennetadmin / ona

OpenNetAdmin IP Address Management (IPAM) system
opennetadmin.com
GNU General Public License v2.0
136 stars 35 forks source link

Input array has 1 params, doERROR => SQL query failed: #126

Closed Gankarloo closed 4 years ago

Gankarloo commented 6 years ago

I belive ADODB has changet somewhat. If you supply 2 vars to the Execute function and one is empty you get this error message.

Adds a check to see if $sqlopt is empty then run Execute without it.

mattpascoe commented 6 years ago

I have a feeling you might have ran into errors caused due to the array not being initialized?

I have the following commit in the develop branch already that I believe might fix what you were seeing? https://github.com/opennetadmin/ona/commit/571631b121944dba213c160be94f93b917f65e42

Mind giving that a try first?

Also just noting the revert of the other pull request I've been lazy about.. just curious if you have been running that code from framer99? I've been too neglectful to test that one.. I think it should just work so if you can confirm it works for you that'd be great :)

Thanks.

Gankarloo commented 6 years ago

Will give your commit a try.

Sorry that was just me being clumsy. But I have plans for testing that, I'll prob get back refarding this in a week or so. And thank you :)

Gankarloo commented 6 years ago

Well apparently "now" is later this week.

I'v tested both your commit 571631b

And #84

Both seems to be working as intended. I'll keep them applied to see if anything else breaks, but I doubt it.

Gankarloo commented 6 years ago

@mattpascoe It has been working fine for almost 2 weeks now so my vote is to apply PR #84 and I will close this PR and create another one with only https://github.com/opennetadmin/ona/commit/571631b121944dba213c160be94f93b917f65e42

mattpascoe commented 4 years ago

Closing this PR.. I think we have accounted for these issues in the development branch. Thanks much.