search

opennetadmin / ona

OpenNetAdmin IP Address Management (IPAM) system
opennetadmin.com
GNU General Public License v2.0
137 stars 35 forks source link

Fixed issue preventing scrolling on some browsers #15

Closed brandt closed 11 years ago

brandt commented 11 years ago

Setting the body style attribute "overflow: hidden" prevents scrolling when rendered content exceeds the window size under certain conditions.

This fix changes the overflow value to "auto" which lets the browser add scrolling when necessary.

mattpascoe commented 11 years ago

I do understand the goal here but it actually creates a few consistency issues. For instance, when you have a workspace that is large, it creates an overflow scroll. That additional size then forces a second scroll bar in the main body. So now there are two scroll bars that are scrolling at different levels.

The intention of the html_desktop is to create a work area that is the same size as the browser window (There are calculations made at various points in the app in case you resize the window). What "should" happen is that the html_desktop is fixed and all things live inside of it with their own 'auto' scroll bars.

I'm aware of a few instances that break this on occasion. I think those are the areas that should get fixed. Are you running into a specific scenario that is not scrolling properly? Also what is your typical resolution? Its best to be at at least 1024x768 or more.

Thanks for the pull request.. you win for being the first :)

brandt commented 11 years ago

Ah, that makes sense. We've been dealing with the issue for a couple years and across a few versions, so I incorrectly assumed this was normal behavior.

I just checked the demo site (which I just discovered) and I now see how it's supposed to behave.

Since the issue is site-specific, I'll close the pull request.

To answer your questions:

We encounter the issue on screens of all sizes. I'm usually running at 1440x900 with the browser window maximized.

It happens consistently in the "display_host" work space. Associated Interfaces and DNS Records tend to run off the screen.

The MOTD runs off the Home screen as well.

Perhaps one of our plug-ins is the cause (e.g. the plug-in content height somehow isn't being factored into overall work space height or isn't recalculated when panes wrap).

I'll fiddle with it more and if I figure out anything useful, I'll be sure to post an update in case someone else finds it useful. In the meantime, at least we have a workaround!

We're big fans of ONA and Github makes it so easy to contribute. Perhaps, too easy... :-)

Thanks, Matt!