opennetworkinglab / aether-onramp

Apache License 2.0
15 stars 22 forks source link

Added support to configure DPDK/SRIOV mode for UPF #22

Closed sureshmarikkannu closed 2 months ago

sureshmarikkannu commented 3 months ago

Added support to configure UPF in DPDK/SRIOV mode

llpeterson commented 3 months ago

Could we have main.yml include the new options/variables, but set to the af_packet defaults, as before, and then add a new main-sriov.yml that includes all the variable settings you need to make sriov/dpdk work (including Intel-specific values). I realize this is redundant, but I view it as a form of documentation... and it matches the approach other optional features take.

gab-arrobo commented 3 months ago

Could we have main.yml include the new options/variables, but set to the af_packet defaults, as before, and then add a new main-sriov.yml that includes all the variable settings you need to make sriov/dpdk work (including Intel-specific values). I realize this is redundant, but I view it as a form of documentation... and it matches the approach other optional features take.

AF_PACKET mode is default (see line #30). I am not sure I understand the comment.

sureshmarikkannu commented 3 months ago

Could we have main.yml include the new options/variables, but set to the af_packet defaults, as before, and then add a new main-sriov.yml that includes all the variable settings you need to make sriov/dpdk work (including Intel-specific values). I realize this is redundant, but I view it as a form of documentation... and it matches the approach other optional features take.

Done

gab-arrobo commented 2 months ago

@llpeterson, this PR is ready. Feel free to merge it when you have a chance. Thanks!