opennetworkinglab / stratum-onos-demo

Stratum+ONOS demo @ ONF Connect 2019 & EuroP4 '19
Apache License 2.0
13 stars 7 forks source link

TH switch does not send LLDPs as packet-in #30

Closed Yi-Tseng closed 5 years ago

pudelkoM commented 5 years ago

I think that is related to #25

ccascone commented 5 years ago

It should not be related as lldp pkts should be matched by the ACL table only

ccascone commented 5 years ago

@Yi-Tseng can this be closed?

ccascone commented 5 years ago

I'm still observing this issue on the latest master.

LLDP packets delivered to TH are not sent to ONOS as packet-in.

ccascone commented 5 years ago

@Yi-Tseng do you remember if your PR #37 fixed this issue? I wonder if the updated P4 program caused the FPM compiler to generate a pipeline config output that breaks packet-in.

ccascone commented 5 years ago

The issue has been fixed by @pudelkoM on stratum_bcm. Packet-ins were delivered to stratum with an invalid dst_port metadata and so were dropped. The default behavior has been changed such that packet-ins are not dropped, while the error about dst_port is still logged.