opennewzealand / linz2osm

Some tools for helping move LINZ data into OpenStreetMap
http://wiki.openstreetmap.org/wiki/LINZ
GNU General Public License v3.0
22 stars 2 forks source link

rendering overlap on the workslice list page #72

Closed HamishB closed 12 years ago

HamishB commented 12 years ago

Hi,

minor cosmetic imperfection: on the workslice list page the units and the selection boxes like to overlap. Only when making the font size tiny in chromium did they not overlap. Firefox (ie iceweasel, debian/stable) stopped letting me reduce font size at about 6pt, but it still was overlapping there.

screenshots of how it looks normally for me, and the amount of "ctrl -" needed to get the columns to line up in chromium: http://bambi.otago.ac.nz/hamish/osm/bugs/workslice_framing.png http://bambi.otago.ac.nz/hamish/osm/bugs/workslice_framing2.png

thanks, Hamish

(is it possible to attach screenshot images to github issues?)

stephend commented 12 years ago

Yeah, if you press 'M' while on this page (and the focus isn't in the text box) you'll get a 'cheat sheet' telling you how to do it. You'll still need to host them, though.

E.g.

workslice framing workslice framing 2

stephend commented 12 years ago

Oh, and there's a fuller explanation of formatting if you click the 'GitHub Flavo(u)red Markdown' link just above the text box on the right side.

HamishB commented 12 years ago

oh, a minor other issue probably not worth opening another ticket for: glad to see the expanded comments box in the tagging page (the box stretch only worked for me in chrome), but it probably doesn't need to be on the individual tagging rules javascript snippets as the vast majority of those are 1-3 lines long. also probably when adding additional tagging options only two need to be added at a time, not three.

Hamish

HamishB commented 12 years ago

... and the workslices page now looks good, both in slightly older vintages of firefox and chrome. the next,prev pagination looks good and works well too.

thanks, Hamish

stephend commented 12 years ago

oh, a minor other issue probably not worth opening another ticket for: glad to see the expanded comments box in the tagging page (the box stretch only worked for me in chrome), but it probably doesn't need to be on the individual tagging rules javascript snippets as the vast majority of those are 1-3 lines long. also probably when adding additional tagging options only two need to be added at a time, not three.

Cool, good idea.

stephend commented 12 years ago

... and the workslices page now looks good, both in slightly older vintages of firefox and chrome. the next,prev pagination looks good and works well too.

Glad you like it. The big thing was making sure the filter stayed filtered: Django has reasonably good built-in pagination otherwise.