search

opennewzealand / linz2osm

Some tools for helping move LINZ data into OpenStreetMap
http://wiki.openstreetmap.org/wiki/LINZ
GNU General Public License v3.0
22 stars 2 forks source link

off-by-one error in the Preview controls #83

Closed HamishB closed 11 years ago

HamishB commented 11 years ago

Hi,

if you set the feature limit to "1" in the preview page, you get no features returned. if you set it to "2" you get 1 feature returned, etc.

Also, while we're at it, I wonder if we could find better words, or add a tooltip, for "Starting ID"? The functionality as it exists now is good*, just the name of it is a little confusing since it can be confused with the raw node id="-7102868" in the preview text. Perhaps "Starting with feature number.. " or something similar?

[*] for example yesterday I set the starting ID to {99,199,299,..,699} to browse through the geographic_name layer until I could find an example of the undocumented "MCUL" feature. No idea how I'd use the node id for, even if I somehow could know what that would be ahead of time.

thanks, Hamish

stephend commented 11 years ago

The off-by-one error is fixed (I had the default starting ID as 0, whereas the IDs really start at 1).

I've added a pile of text to the form explaining the ID. I still don't think it's hugely clear, though.

HamishB commented 11 years ago

one other minor cosmetic I noticed on the Preview page is that if you leave the dataset as "-------" and press the go button you get a red backgrounded error message saying the option is required. but it doesn't say which option is required.

I've added a pile of text to the form explaining the ID. I still don't think it's hugely clear, though.

The feature ID refers to the internal feature ID, ogc_fid, which starts at 1. This ID is for convenience in using the preview ONLY, and should not be uploaded to OSM. The unrelated IDs that appear in the XML are generated on-the-fly and refer to the individual nodes.

re. "and should not be uploaded to OSM", is it even possible to do that?

re. "The unrelated IDs that appear in the XML...", perhaps something like "The unrelated node IDs that appear in the preview text are generated on-the-fly and refer to the individual coordinate points." as the end-user may not know what XML means, but can see the text in front of them.

??

thanks, Hamish B

stephend commented 11 years ago

Re: selecting dataset: it refers to the field directly underneath it. The behaviour is built-in to Django, although I have a bit of control over the layout. This is now issue #84.

Re: should not be uploaded to OSM: I can think of some ways it's possible. I'd like people not to try.