opennewzealand / linz2osm

Some tools for helping move LINZ data into OpenStreetMap
http://wiki.openstreetmap.org/wiki/LINZ
GNU General Public License v3.0
22 stars 2 forks source link

failure to draw overlapping polygons in workslice view #93

Open HamishB opened 11 years ago

HamishB commented 11 years ago

Hi,

when you checkout at a coarser box size over the top of an earlier checkout, the resulting shaded polygon is not rendered on the map view.

two examples: http://linz2osm.openstreetmap.org.nz/workslices/215/show/ http://linz2osm.openstreetmap.org.nz/workslices/219/show/

also, "View bounding box On openstreetmap.org" for those just zooms in on a nearby bit of ocean.

thanks, Hamish B

stephend commented 11 years ago

Do you mean a checkout where the whole of its extent is already part of one or more existing checkouts? Or any checkout that covers existing checkouts?

HamishB commented 11 years ago

for workslice 219 I think the checkout was over the top of the whole layer's bbox.

this should all be all greened: http://linz2osm.openstreetmap.org.nz/workslices/create/layer_in_dataset/30/

stephend commented 11 years ago

I can reproduce this issue only for checkouts that are complete overlaps, not partial overlaps. Such checkouts are not usually supposed to result in any features being selected, and since zero-feature checkouts aren't permitted, shouldn't normally happen. I'm downgrading this to the long term wishlist.

HamishB commented 11 years ago

I can reproduce this issue only for checkouts that are complete overlaps, not partial overlaps. Such checkouts are not usually supposed to result in any features being selected,

why not? a typical case would be if you had finished all the fine work, and did a final big-area checkout of the area to catch any blocks you'd previously missed.

stephend commented 11 years ago

I mean a complete overlap in the sense that every square metre of the checkout is already included in previous checkouts - which at the moment shouldn't produce any features. (It will in future as part of #97 - in that case I'll actually display the checkouts as overlapping).