search

opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://open-next.js.org
MIT License
3.9k stars 119 forks source link

Fix node crashing when used without stream #498

Closed conico974 closed 1 month ago

conico974 commented 1 month ago

This fix a weird issue of Node crashing with 3.1 for some route. I can't even figure out why some routes work and why some don't.

For some reason Node crash silently if the OpenNextNodeResponse is not piped to a writable. Even inside a try/catch, node just stop running with no visible logs. Link to the discord thread https://discord.com/channels/983865673656705025/1276418643080511529

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 4:55pm
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f3e22b6c2b144232307245f9e72ff6bd17ca6de5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ---------------- | ----- | | open-next | Patch | | app-pages-router | Patch | | app-router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR