opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://opennext.js.org
MIT License
4.06k stars 125 forks source link

Publish release 3.1.4 to npm #549

Open socsieng opened 5 days ago

socsieng commented 5 days ago

Release 3.1.4 has been created, however, it hasn't been published to npm yet. Is there anything special, or any additional processes required in order to publish to npm?

conico974 commented 5 days ago

This is published to npm, but the name has changed https://www.npmjs.com/package/@opennextjs/aws

I'll keep this open for now so that other people can see it

socsieng commented 4 days ago

For anyone else who is using with SST, the following can be used until SST is updated to include: https://github.com/sst/ion/issues/1227#issuecomment-2407740948

new sst.aws.Nextjs("nextjs", {
  buildCommand: "npx @opennextjs/aws build",
  // ...
});
MisterJimson commented 2 days ago

Hmm will this break sstv2? We are passing the version like:

  const site = new NextjsSite(stack, 'dashboard-beta', {
    path: 'packages/dashboard',
    customDomain: customDomain,
    bind: getDefaultFunctionBindings(app),
    permissions: getDefaultFunctionPermissions(app),
    openNextVersion: '3.0.8',
conico974 commented 2 days ago

@MisterJimson Exact same fix as for V3

buildCommand: "nxp @opennextjs/aws@3.1.6 build"

There is a PR for this in SST v2, haven't checked if it has been merged or not

MisterJimson commented 2 days ago

And we would remove openNextVersion?

conico974 commented 2 days ago

It doesn't matter because openNextVersion will be overrided by the custom buildCommand. But it's probably better to remove it to avoid confusion

niklaswallerstedt commented 2 days ago

Here's the PR https://github.com/sst/sst/pull/3873