search

opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://opennext.js.org
MIT License
4.14k stars 126 forks source link

Add unit tests for handling middleware #576

Closed socsieng closed 4 weeks ago

changeset-bot[bot] commented 4 weeks ago

⚠️ No Changeset found

Latest commit: 01103dda883976e8abd1afdd9a730056321b92f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 4 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@576

commit: 01103dd

socsieng commented 4 weeks ago

It's fine for now i guess, we can change it later if needs be We could add a note at the top to remind us about that

What kind of note, and where did you have in mind?

conico974 commented 4 weeks ago

It's fine for now i guess, we can change it later if needs be We could add a note at the top to remind us about that

What kind of note, and where did you have in mind?

Something at the top of the test file. Something like : Ideally we'd want to not test this function as a whole, but rather break it into smaller component and test these component independently