Add unit test coverage reporting

opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS

https://opennext.js.org

MIT License

4.14k stars 126 forks source link

Add unit test coverage reporting #578

Closed socsieng closed 3 weeks ago

socsieng commented 4 weeks ago

Example output: https://github.com/opennextjs/opennextjs-aws/actions/runs/11415198269#summary-31764988744

changeset-bot[bot] commented 4 weeks ago

⚠️ No Changeset found

Latest commit: e1435150eca071fe2af1536f3ee1e260445b4ca2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

conico974 commented 4 weeks ago

Do we want to add this ? That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense. cc @khuezy

socsieng commented 4 weeks ago

Do we want to add this ? That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense. cc @khuezy

I thought it could serve as a reminder to include tests for future contributions

conico974 commented 4 weeks ago

Do we want to add this ? That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense. cc @khuezy

I thought it could serve as a reminder to include tests for future contributions

That's a good point, but given how some stuff cannot be unit tested i wonder if it won't make people try to write test and us having to ask to remove them and having to explain this everytime.

Or maybe it won't have any effect, the changeset bot as been there for a while and almost no PR contains a changeset :joy:

Btw i've checked it doesn't work right now because the GH action don't have the permission to write PR

socsieng commented 4 weeks ago

Btw i've checked it doesn't work right now because the GH action don't have the permission to write PR

I noticed that too. I set the permissions in the workflow file but I'm guessing it's related to my permissions on this repository.

I tested it out on my fork and it works as expected: https://github.com/socsieng/open-next/pull/1#issuecomment-2423790167

It might work for subsequent pull requests after merge... 🤞

khuezy commented 3 weeks ago

We can merge and figure out the permissions issues if there are any.