search

opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://opennext.js.org
MIT License
4.14k stars 126 forks source link

Refactor overrides #579

Closed conico974 closed 3 weeks ago

conico974 commented 4 weeks ago

Fix #570 For review you probably want to look commit by commit

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 8b31c4ab49fbad2e23478c01ac5bbab7e231b220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ---------------- | ----- | | @opennextjs/aws | Minor | | app-pages-router | Patch | | app-router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 4 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@579

commit: 54c48da

conico974 commented 3 weeks ago

Looks good. Maybe move "added and fixed eslint rules for type import" in a separate PR to remove the noise from here?

@vicb That's probably a good idea yeah I think this one ( along with #574 ) should be considered minor because they could break existing code. This one for custom overrides and the other one because it change the way to modify sharp install

conico974 commented 3 weeks ago

I've merged this one, but i'll stop the e2e test as they are broken at the moment. I've run the e2e test on my account and it works