search

opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://opennext.js.org
MIT License
4.14k stars 126 forks source link

feat(middleware): add ability to force single build pass #613

Closed vicb closed 2 weeks ago

vicb commented 2 weeks ago

This is the second (and last) hack required for the middleware bundle on cloudflare.

For us the second build pass is hanlded by wrangler. This PR adds an option to disable that pass.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 3b372b6824957cf1fc020befb3bc1320e0ddeb46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ---------------- | ----- | | @opennextjs/aws | Patch | | app-pages-router | Patch | | app-router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@613

commit: 3b372b6

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 19.32% 1410 / 7298
🔵 Statements 19.32% 1410 / 7298
🔵 Functions 53.14% 93 / 175
🔵 Branches 67.27% 333 / 495
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createMiddleware.ts 0% 0% 0% 0% 1, 19-23, 25, 28-33, 35, 39-41, 44-48, 51-65, 67-81
Generated in workflow #677 for commit 3b372b6 by the Vitest Coverage Report Action
vicb commented 2 weeks ago

FYI you can't merge multiple PR at the same time without crashing the e2e test (the cdk cannot update an app that are already in the UPDATE_IN_PROGRESS state ) You need to wait for the end of the previous e2e test. Also something that we should rework in the future.

Ah cool, I was just looking at why tests failed. Thanks!