opennextjs / opennextjs-aws

Open-source Next.js adapter for AWS
https://opennext.js.org
MIT License
4.14k stars 126 forks source link

refactor(overrides): move types to top level types folder #619

Closed vicb closed 1 week ago

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 0b80b28ad0984c4321fe0ce0a7472387e8a75516

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 1 week ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@619

commit: 0b80b28

github-actions[bot] commented 1 week ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.43% 1650 / 7355
🔵 Statements 22.43% 1650 / 7355
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.57% 415 / 588
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 78.13% 84.26% 87.5% 78.13% 122-123, 186-188, 191-199, 249-260, 411-420, 431-472
packages/open-next/src/core/createGenericHandler.ts 0% 0% 0% 0% 1-55
packages/open-next/src/core/createMainHandler.ts 0% 0% 0% 0% 1-66
packages/open-next/src/core/resolve.ts 0% 100% 100% 0% 18-140
packages/open-next/src/core/routing/cacheInterceptor.ts 89.56% 64.44% 100% 89.56% 31, 42-47, 61-62, 102, 139-140, 145-146, 152-154, 209-210
packages/open-next/src/overrides/converters/aws-apigw-v1.ts 96.7% 82.6% 100% 96.7% 89-91
packages/open-next/src/overrides/converters/aws-apigw-v2.ts 92.79% 83.33% 100% 92.79% 44, 48-51, 107-109
packages/open-next/src/overrides/converters/aws-cloudfront.ts 70.31% 80.76% 100% 70.31% 105-106, 156-215
packages/open-next/src/overrides/converters/dummy.ts 0% 100% 100% 0% 8-24
packages/open-next/src/overrides/converters/edge.ts 0% 0% 0% 0% 1-112
packages/open-next/src/overrides/converters/node.ts 92% 86.66% 66.66% 92% 50-53
packages/open-next/src/overrides/converters/sqs-revalidate.ts 0% 100% 100% 0% 6-28
packages/open-next/src/overrides/imageLoader/dummy.ts 0% 0% 0% 0% 1-11
packages/open-next/src/overrides/imageLoader/host.ts 0% 0% 0% 0% 1-35
packages/open-next/src/overrides/imageLoader/s3.ts 0% 0% 0% 0% 1-46
packages/open-next/src/overrides/incrementalCache/dummy.ts 0% 100% 100% 0% 3-16
packages/open-next/src/overrides/incrementalCache/s3-lite.ts 0% 0% 0% 0% 1-93
packages/open-next/src/overrides/incrementalCache/s3.ts 0% 0% 0% 0% 1-79
packages/open-next/src/overrides/originResolver/dummy.ts 0% 100% 100% 0% 3-10
packages/open-next/src/overrides/originResolver/pattern-env.ts 0% 0% 0% 0% 1-51
packages/open-next/src/overrides/queue/dummy.ts 0% 100% 100% 0% 3-10
packages/open-next/src/overrides/queue/sqs-lite.ts 0% 0% 0% 0% 1-61
packages/open-next/src/overrides/queue/sqs.ts 0% 0% 0% 0% 1-28
packages/open-next/src/overrides/tagCache/dummy.ts 0% 100% 100% 0% 4-20
packages/open-next/src/overrides/tagCache/dynamodb-lite.ts 0% 0% 0% 0% 1-213
packages/open-next/src/overrides/tagCache/dynamodb.ts 0% 0% 0% 0% 1-158
packages/open-next/src/overrides/warmer/aws-lambda.ts 0% 0% 0% 0% 1-83
packages/open-next/src/overrides/warmer/dummy.ts 0% 100% 100% 0% 3-10
packages/open-next/src/overrides/wrappers/aws-lambda-streaming.ts 0% 0% 0% 0% 1-122
packages/open-next/src/overrides/wrappers/aws-lambda.ts 0% 0% 0% 0% 1-76
packages/open-next/src/overrides/wrappers/cloudflare.ts 0% 100% 100% 0% 6-57
packages/open-next/src/overrides/wrappers/dummy.ts 0% 100% 100% 0% 3-9
packages/open-next/src/overrides/wrappers/node.ts 0% 0% 0% 0% 1-69
packages/open-next/src/plugins/resolve.ts 0% 0% 0% 0% 1-103
packages/open-next/src/types/open-next.ts 0% 0% 0% 0%
packages/open-next/src/types/overrides.ts 0% 0% 0% 0%
Generated in workflow #712 for commit 0b80b28 by the Vitest Coverage Report Action
khuezy commented 1 week ago

ooof lots of type errors now.

vicb commented 1 week ago

looks like I missed a few files 😅