search

opennextjs / opennextjs-cloudflare

Open Next.js adapter for Cloudflare
https://opennext.js.org/cloudflare
MIT License
378 stars 8 forks source link

Pin next to the catalog version #112

Closed vicb closed 2 weeks ago

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: b2dd363d5bfb86aa37b99f754a13e7e0cf680254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@112

commit: b2dd363

vicb commented 2 weeks ago

We should definitely work on improving testing (there is an issue related to that).

But for now I don't want to have to update the apps (to match the latest Next) while I'm working on the open next integration.

vicb commented 2 weeks ago

these are also unpinned: vercel-commerce/next-deps

It's pinned (but not to the catalog version).

dario-piotrowicz commented 2 weeks ago

It's pinned (but not to the catalog version).

yeah sorry that's what I meant 😅

vicb commented 2 weeks ago

I don't fully agree with this change but I'm not super against it (since we're doing this in the create-next-app example)

It's only temporary and we will improve tests as part of #108

Thanks!