opennextjs / opennextjs-cloudflare

Open Next.js adapter for Cloudflare
https://opennext.js.org/cloudflare
MIT License
378 stars 8 forks source link

Expand missing next.config error message #84

Closed shashankboosi closed 1 month ago

shashankboosi commented 1 month ago

Fixes https://github.com/opennextjs/opennextjs-cloudflare/issues/82

Found out that next dev can run the a Next.js app without next.config but if we are using the adapter we throw an error if we don't find the config

1) So added a detailed error to point towards adding the next.config to run the application. 2) Updated wrangler to it's latest version 3) Also added the vercel blog starter into the examples which is what I used to debug the issue mentioned

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: f0455317aefd6e869fa278c322d1c60134f8f256

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@84

commit: f045531

vicb commented 1 month ago

OOps, I should have read the PR description.

Would you mind splitting 1, 2, and 3 into different PRs?

Thanks!

shashankboosi commented 1 month ago

@vicb Will create different PRs, should I add patch changeset for all the PRs?

vicb commented 1 month ago

Thanks!

should I add patch changeset for all the PRs?

I would say only the error message fix. It's not the biggest change but it will be very valuable to users.

shashankboosi commented 1 month ago

I will close this and open separate PRs. Thanks!