search

opennic / opennic-web

Official OpenNIC Homepage
https://www.opennic.org/
46 stars 13 forks source link

Adding rel="noopener" to external links #18

Closed Fusl closed 6 years ago

Fusl commented 7 years ago

https://developers.google.com/web/tools/lighthouse/audits/noopener

jonaharagon commented 7 years ago

Deploy preview ready!

Built with commit b43ba43dba5bb8ad95eb8c769c63355fe253d170

https://deploy-preview-18--opennic.netlify.com

jonaharagon commented 7 years ago

I'm reading into this and it occurs to me that I type target=“_blank” in basically all my links because that’s how I browse the web, but it strikes me that others may not be expecting this behavior. https://css-tricks.com/use-target_blank/ makes a good argument in that direction. What do you think about just removing all the target=“_blank”s entirely?

jonaharagon commented 6 years ago

I recommend passing #25 instead of this PR.