search

openoakland / OakCrime-Decommissioned

Code supporting citizen analysis of crime in Oakland, CA
22 stars 16 forks source link

Configured CircleCI to test via Docker #53

Closed clintonb closed 5 years ago

adborden commented 5 years ago

This seems a little funny to me. Usually the CI commands mirror what you run in development. This keeps things simple and consistent. This way you know that what is running in CI is very similar to what you are running in development. Are these commands what has to be run for development in docker?

I would expect to run things like make docker.pull, make docker.build, and make test or something. Or maybe just docker-compose up. If there's a special compose config involved, lets' wrap that in a make command, e.g.

ci:
        docker-compose -f docker-compose.yml -f docker-compose.ci.yml run app make test
adborden commented 5 years ago

CI currently tests the app without docker. This is ok for now.