search

openoakland / funding-public-safety

Helping Oaklanders understand the real impacts of public safety funding.
https://openoakland.github.io/funding-public-safety/
4 stars 6 forks source link

Hamburger menu on mobile not expandable #74

Closed theecrit closed 2 years ago

theecrit commented 2 years ago

Description

The global nav menu collapses to a hamburger icon when the viewport shrinks, as expected. However, tapping on it is non-responsive, rendering navigation impossible on mobile.

Tested with Firefox and Safari on iOS 14.8.

This may be due to Bootstrap nav implementation or possibly the superfluous 11ty nav plugin that isn't properly configured. We should be using one or the other.

jaedoak commented 2 years ago

@aemann2 FYI, I have a local fix for this -- let me know if it would be helpful. If you've already fixed this, ignore this comment. :)

aemann2 commented 2 years ago

@aemann2 FYI, I have a local fix for this -- let me know if it would be helpful. If you've already fixed this, ignore this comment. :)

If you want to open up a PR for this, that would be great!

jaedoak commented 2 years ago

I opened up a PR, but I've never worked with this kind of templating system before, so please double-check that I used the right approach! (I just modified the page and home files, and let npm run build take care of the *.html updates).

If I want to learn more about how you're building this site, what should I read up on? Nunjucks?

theecrit commented 2 years ago

@jaedoak So the nice thing about Eleventy is that you can use multiple templating frameworks: https://www.11ty.dev/docs/languages/

aemann2 commented 2 years ago

Fixed by #91