Fix placement of error component on Upload page

openoakland / woeip

A platform for impacted communities to understand their local air quality and advocate for environmental justice.

https://woaq.org

MIT License

29 stars 16 forks source link

Fix placement of error component on Upload page #357

Open theecrit opened 3 years ago

theecrit commented 3 years ago

Description

When uploading a single file, the error message component displays at the bottom of the screen, overlapping the footer. Still to investigate: whether this happens for just a single file upload error, or all errors/alerts.

Steps to reproduce

Go to woaq.org
Select "Upload" in global nav
Select "upload files" or drag a single csv file to the drop zone.
See error display in wrong location.

Expected behavior

The error component should display in between the drop zone and the list of uploaded file names, per the wireframes.

Screenshots

TBd

Desktop configuration

OS: 10.15.x
Browser: Firefox

Additional context

This is a holdover from when we moved to Create React App.

Affected Components (For Developers)

List what pages or backend files will need to be added, removed, or changed

Technical Resources (For Developers)

Figma wireframes (see "4 - File selection, 1 of each type" et al)

theecrit commented 2 years ago

Maybe look at the component order.

dabryant11 commented 2 years ago

I've got a fix for this but having a 403 issue when trying to push can someone help me? :)

exchrotek commented 2 years ago

@theecrit @TangoYankee is this a lack of permissions issue causing the 403 error?

theecrit commented 2 years ago

Hmm, not sure. @dabryant11, can you describe the steps you're taking that produce the 403?

mnorelli commented 2 years ago

I got 403's before Jess gave me edit rights for my first PR...

On Thu, Mar 24, 2022 at 4:33 AM Jess Sand @.***> wrote:

Hmm, not sure. @dabryant11 https://github.com/dabryant11, can you describe the steps you're taking that produce the 403?

— Reply to this email directly, view it on GitHub https://github.com/openoakland/woeip/issues/357#issuecomment-1077529381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFFW3IGNCXHZZGOBPTXIODVBRHH7ANCNFSM5B6PKAQA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dabryant11 commented 2 years ago

Thank you all for the replies! It seems that it may a permissions issue because I created a new branch, made the fix, git add, git commit then git push and received this error

@theecrit @mnorelli @exchrotek

theecrit commented 2 years ago

@dabryant11 Okay, try now? I've added you as a collaborator, so hopefully that works. I can tweak permissions if needed.

dabryant11 commented 2 years ago

It seems like there may need to be a tweak? 😅

@theecrit

theecrit commented 2 years ago

@dabryant11 Ack, sorry — you should be good now!!

dabryant11 commented 2 years ago

good to go and PR posted - thank you! @theecrit

theecrit commented 2 years ago

Issue can be closed once we resolve/address the failing test in PR #452

dabryant11 commented 2 years ago

@theecrit seems like the only issue with testing was a warning and @gsehrlich said that this could be ignored (https://github.com/openoakland/woeip/pull/452) please confirm and if so I will merge

gsehrlich commented 2 years ago

@dabryant11 The warning in drop.test.js can be ignored, but there was a new warning related to your PR that I'm not familiar with. I wouldn't recommend ignoring it