search

openoakland / woeip

A platform for impacted communities to understand their local air quality and advocate for environmental justice.
https://woaq.org
MIT License
29 stars 16 forks source link

Update content and respective global nav options #374

Closed theecrit closed 2 years ago

theecrit commented 3 years ago

Description

The current global navigation includes links to About, Upload, and Maps. These options need to be updated to reflect the MVP information architecture.

Acceptance criteria

Dependencies and other considerations

gsehrlich commented 2 years ago

(Edited) Just checked some boxes. Do we still want "West Oakland's Air" in MVP?

theecrit commented 2 years ago

@gsehrlich I've got a branch going locally and have managed to create the pages and update the nav menu. But I'm having trouble with the export const {page-name} = () => ( on line 4 of the index.js file — I'm not sure what to replace {page-name} with to get the content container to display.

gsehrlich commented 2 years ago

Oh nice! Whatever you replace {page-name} with will be the variable you use to render the component. For example, in web/src/components/home, it's called Home. Then, in web/src/components/nav/switch.js, you need to import it and add it like the other pages. Let me know if that works!

theecrit commented 2 years ago

I think I'm having trouble with the apostrophe in "West Oakland's Air" — I've tried all of the following approaches to no avail:

'West Oakland's Air' "West Oakland's Air" West Oakland\'s Air "West Oakland\'s Air" 'West Oakland\'s Air'

ETA: and also west-oaklands-air, which is the assigned slug in bar.js. `

gsehrlich commented 2 years ago

I’d suggest WestOaklandsAir. It doesn’t have to match the actual title; you just need to refer back to it in switch.js. But it does have to follow javascript variable naming conventions.

On Fri, Jun 3, 2022 at 2:17 PM Jess Sand @.***> wrote:

I think I'm having trouble with the apostrophe in "West Oakland's Air" — I've tried all of the following approaches to no avail:

'West Oakland's Air' "West Oakland's Air" West Oakland\'s Air "West Oakland\'s Air" 'West Oakland\'s Air'

— Reply to this email directly, view it on GitHub https://github.com/openoakland/woeip/issues/374#issuecomment-1146369227, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACT5UIS23GEZFWSNZRRXIMDVNJY7DANCNFSM5F4FKZIA . You are receiving this because you were mentioned.Message ID: @.***>

theecrit commented 2 years ago

Oh, derp! I completely missed updating switch.js. Thank you, worked a treat!