search

openoakland / woeip

A platform for impacted communities to understand their local air quality and advocate for environmental justice.
https://woaq.org
MIT License
29 stars 16 forks source link

Draft: 346: account management #384

Open wendy-wm-wu opened 3 years ago

wendy-wm-wu commented 3 years ago

Checklist

Description

Issue: #346

Brief description of solution This is a POC for account management. This ticket will register, log-in, load, and log-out a user; it also verifies authentication and generates a JWT token.

The password reset feature is not complete and will be taken up in a different story. We also will include further CSS changes as a separate story.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for woeip ready!

🔨 Explore the source changes: 7f8bbc9e805621e8626034aa97aa96ae8c771b33

🔍 Inspect the deploy log: https://app.netlify.com/sites/woeip/deploys/62072ba33aa16d0007da2835

😎 Browse the preview: https://deploy-preview-384--woeip.netlify.app

TangoYankee commented 2 years ago

@theecrit @wendy-wm-wu I wasn't able to access the Netlify logs directly. However, I did attempt to build the application locally and found the front end failed to compile. I imagine the local and Netlify builds are failing for similar reasons.

wendy-wm-wu commented 2 years ago

Thanks, @TangoYankee for looking into this. I'll go take a look. I must have missed this since I didn't re-run after rebasing.

TangoYankee commented 2 years ago

@wendy-wm-wu , would you be open to splitting this into two separate PRs- one for the front end and another for the backend? It should make it simpler review each one individually.

wendy-wm-wu commented 2 years ago

@TangoYankee - Sorry for the late reply. I keep forgetting to check my other email that's linked to this GitHub. Since this is a PR with so many commits between both Alana and myself, I think it would be easier to leave as is if that's okay. In the future, we won't have a large MR like this and will split into frontend/backend.

Also, thank you so much for reviewing and for your thoughtful comments. I'll take a look soon.

wendy-wm-wu commented 2 years ago

@TangoYankee - Did you check your email? I think you have to click the url provided in the email, which will take you back to the site. There should be a button (still requires some CSS changes) on the page that you'll then click to activate your account.

TangoYankee commented 2 years ago

@TangoYankee - Did you check your email? I think you have to click the url provided in the email, which will take you back to the site. There should be a button (still requires some CSS changes) on the page that you'll then click to activate your account.

Even if we are utilizing email as part of the account creation process, the initial request should not return an error.

sribbleinc commented 2 years ago

@TangoYankee Both Wendy and I have never seen this error before. Would you be able to record yourself producing the error to send to us? Or let us know if you want to schedule a time to go over it together.

TangoYankee commented 2 years ago

@wendy-wm-wu I was able to sign in successfully. However, after I signed in, attempting to upload or view data was prevented by 401 errors.

wendy-wm-wu commented 2 years ago

@TangoYankee - I looked into the issue, and I think we need to send "JWT token" with every request that we make. This will also require some backend changes that I'll need to dig into.

TangoYankee commented 2 years ago

@wendy-wm-wu The upload page is working. It seems the map page needs the same treatment.

sribbleinc commented 2 years ago

Hey @TangoYankee Wendy and I have found an issue with token persistence that we need to look into. We'll let you know when you can review again.

wendy-wm-wu commented 2 years ago

@TangoYankee - Oops, that MR was not ready for review yet. I pushed up the initial change, so Alana could work on it. I've been using my company laptop to develop, and last week, I had to remove Docker desktop since it won't be free for commercial use anymore. Unfortunately, the Docker alternatives that I looked into do not support docker-compose. I'm going to try to set this up on my very slow personal computer, so I can start developing again. Like Alana mentioned, we'll let you know when this MR will be ready for review. Thanks for your patience.