[x] Reference the open issue that the pull request addresses
[x] Pass code quality checks
spin up docker docker-compose up -d --build
enter api container docker-compose exec api /bin/bash
run api tests make validate
exit container ctrl/command+D or exit
enter web container docker-compose exec web /bin/sh
run front-end tests npm run test or npx jest
lint npm run lint:fix
exit container as above
[x] Request code review
Please allow 36 hours from opening a pull request before merging a pull request- even if it has already received an approving review.
[ ] Address comments on code and resolve requested changes
[ ] Merge own code
Description
Issue: #331
Show values and colors for points on the map
Brief description of solution
Implementing the ReactJS onHover wrapper for the same Mapbox function, this code gathers an object of point data under the mouse hover, including their pollutant values and timestamps, and displays a popup box showing the most recently collected point and its pollutant value along a colorbar of EPA categories. If the zoom level creates a large enough hover radius, the popup box also shows the next five points in that radius. If more than six points are in the hover collection, only their count is listed.
Adding support for mobile, click events, and additional EPA background information, requested in this ticket, has not yet been addressed.
Failed tests
Not sure how to address three (3) front-end test failures related to src/components/upload/drop.test.js, code not addressed or edited in this issue.
Checklist
docker-compose up -d --build
docker-compose exec api /bin/bash
make validate
ctrl/command+D
orexit
docker-compose exec web /bin/sh
npm run test
ornpx jest
npm run lint:fix
Description
Issue: #331 Show values and colors for points on the map
Brief description of solution Implementing the ReactJS onHover wrapper for the same Mapbox function, this code gathers an object of point data under the mouse hover, including their pollutant values and timestamps, and displays a popup box showing the most recently collected point and its pollutant value along a colorbar of EPA categories. If the zoom level creates a large enough hover radius, the popup box also shows the next five points in that radius. If more than six points are in the hover collection, only their count is listed.
Adding support for mobile, click events, and additional EPA background information, requested in this ticket, has not yet been addressed.
Failed tests
Not sure how to address three (3) front-end test failures related to
src/components/upload/drop.test.js
, code not addressed or edited in this issue.