"Files match" message when files don't match - Githubissues

openoakland / woeip

A platform for impacted communities to understand their local air quality and advocate for environmental justice.

https://woaq.org

MIT License

29 stars 16 forks source link

"Files match" message when files don't match #460

Closed gsehrlich closed 2 years ago

gsehrlich commented 2 years ago

Describe the bug Arbitrary pairs of files will trigger a "Success! Your files match" message.

To Reproduce Steps to reproduce the behavior:

Go to "Upload"
Create two blank text files
Drag and drop both into the upload field
See success message

Expected behavior The files are rejected with a "Files don't match" message or a "Neither file is in a GPS or DusTrak format" message.

Desktop (please complete the following information):

OS: Windows 11
Browser: Brave
Version 1.37.116 Chromium: 100.0.4896.127

Labels

[x] Add a status label
- needs definition
- needs help
- ready to work on
- in progress
- backlog
[x] Add a bug label
[x] Add additional labels as needed

theecrit commented 2 years ago

Seems like the checks being run aren't catching file format. We have an error message for that in the wires.