openoakland / woeip

A platform for impacted communities to understand their local air quality and advocate for environmental justice.
https://woaq.org
MIT License
29 stars 16 forks source link

As a developer, I would like to be able to read and more easily understand the code for the click/hover popup box on the map #493

Open gsehrlich opened 2 years ago

gsehrlich commented 2 years ago

Is your feature request related to a problem? Please describe. The click/hover popup box on the map works, but I implemented it hastily and the code is a bit messy. Some refactoring would clear it up. The prototypes at the bottom may also be missing for some variables.

Describe the solution you'd like Refactor.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Let's make sure we actually want the hover/click interaction before we put too much energy into refactoring it.

Labels

For Developers

Affected Components I think mostly web/src/components/map/menu.js and ./hover.js.

Testing Outline Currently this functionality is not tested. Some tests would be a good idea...