openoereb / pyramid_oereb_mfp

Implementation of a static extract (PDF export) for the pyramid_oereb server with MapFish-Print
1 stars 3 forks source link

PDF extract not created using IDENTDN & NUMBER call option #105

Closed voisardf closed 2 years ago

voisardf commented 2 years ago

Hi,

when calling the PDF by this kind of request: http://localhost:6543/oereb/extract/pdf/?IDENTDN=NE127672&NUMBER=7672

@jwkaltz @marionb @vvmruder :the extract generation fails - this is because the EGRID is not set but a value is expected by pyramid_oereb_mfp for now.

The EGRID line in the extract is mandatory, but not the existence of an EGRID value (otherwise the IDENTDN&NUMBER option has no sense); so we need to fix the templates and accept EGRID = NONE - if and only if EGRID is None and IDENTDN and Number are set.

The case above appears quite frequently in NE as no EGRID is given to real_estate with an modification ongoing in the land registry. Only somewhere near the end of the process the new EGRID will be set.

I hope my description is clear enough?

voisardf commented 2 years ago

In the specs, this example is explicitely mentionned on page 8, point 3.2.1 last example

voisardf commented 2 years ago

This also means minor adaptions in the print_proxy I think: https://github.com/openoereb/pyramid_oereb/blob/master/pyramid_oereb/contrib/print_proxy/mapfish_print/mapfish_print.py#L169-L170 I suggest to use the combination of IDENTDN and Number to set the archive path if no egrid is set

voisardf commented 2 years ago

solved