search

openoereb / pyramid_oereb_mfp

Implementation of a static extract (PDF export) for the pyramid_oereb server with MapFish-Print
1 stars 3 forks source link

105 set optional egrid #106

Closed voisardf closed 2 years ago

voisardf commented 2 years ago

I suggest to set a default value to None (or '') for the RealEstate_EGRID to get the PDF created. Both work for me to fix issue https://github.com/openoereb/pyramid_oereb_mfp/issues/105

marionb commented 2 years ago

@voisardf this looks good to me.

Just one thing: in #105 you mentioned

so we need to fix the templates and accept EGRID = NONE - if and only if EGRID is None and IDENTDN and Number are set

We should add a check for this but perhaps in the print proxy. I am not sure if this is possible in the templates. What do you thing?

voisardf commented 2 years ago

@marionb yes, sorry! - that is what I meant. :) 👍

voisardf commented 2 years ago

@marionb : no, there is no issue yet, I'll create one now