Unify use of dashes when no Data

openoereb / pyramid_oereb_mfp

Implementation of a static extract (PDF export) for the pyramid_oereb server with MapFish-Print

1 stars 3 forks source link

Unify use of dashes when no Data #108

Closed marionb closed 2 years ago

marionb commented 2 years ago

fix #99 The templates now use the same dash every where when no data is given. The dash is configured in Report.properties and needs to be translated.

@michmuel and/or @voisardf can you:

should I adapt the RM translation or is there a reason why this is different? https://github.com/openoereb/pyramid_oereb_mfp/blob/master/print-apps/oereb/Report_rm.properties#L30
can you check if this dash if fine and the templates work? (I do not have use cases for everything)

michmuel commented 2 years ago

Addendum to the review: Screenshot from 2022-04-29 11-25-56

marionb commented 2 years ago

Hmm that is interesting this is not the case for me. @michmuel Do you have the titles in the spec? And on mater are the titles showing? What is your pyramid_oereb config.yaml. Perhaps I have some other settings for which this case is not appearing (I know this is not a very obvious explanations but it is the only I came up with on the fly ;-) )

michmuel commented 2 years ago

Sorry. There was a copy/paste error on my side.