search

openoereb / pyramid_oereb_mfp

Implementation of a static extract (PDF export) for the pyramid_oereb server with MapFish-Print
1 stars 3 forks source link

implementation of QR Code detail band #114

Closed voisardf closed 2 years ago

voisardf commented 2 years ago

Adds a detail band to the TOC to print the QR code. Needs PR https://github.com/openoereb/pyramid_oereb/pull/1579 to work. It's debatable if we should enable a switch to print or not the qr code as it's optional. I'm also open to discuss the best layout option to fit the specs (we could add it to the disclaimer band rather than create a new detail band)

jwkaltz commented 2 years ago

Regarding the "make it optional": ideally it would be handled like for example display_certification / Display_Certification, meaning: you can configure in the oereb service YAML whether you want the QR code or not, and you can keep the standard print templates and config without adapting them.

See https://github.com/openoereb/pyramid_oereb/blob/720af9163253d7253ded559c8914f4d87533325f/dev/config/pyramid_oereb.yml.mako#L92 and https://github.com/openoereb/pyramid_oereb_mfp/blob/6ef4c18f8059bbb62741a67e831ed4003695e68d/print-apps/oereb/pdfextract.jrxml#L51

voisardf commented 2 years ago

@jwkaltz @michmuel I added the QR display option, but I felt like putting it to true by default 😃 @marionb I also did the regrouping in a disclaimer and QR code subreport, but I have the feeling there is always a page break after the QR code. So if that is true and you know the way to fix this behaviour I'd be glad if you could tell me how...

voisardf commented 2 years ago

@michmuel ok for you if I merge this PR?

michmuel commented 2 years ago

Yes.