search

openoereb / pyramid_oereb_mfp

Implementation of a static extract (PDF export) for the pyramid_oereb server with MapFish-Print
1 stars 3 forks source link

Make municipality name optional in the output #132

Closed jwkaltz closed 1 year ago

jwkaltz commented 1 year ago

Fixes #129 , replaces #130 : Make municipality name optional in the output. Must be done simultaneously to https://github.com/openoereb/pyramid_oereb/pull/1703

jwkaltz commented 1 year ago

Tested on dummy installation, output when parameter is set to true: parameter-set-to-true Output when parameter is set to false: parameter-set-to-false

michmuel commented 1 year ago

I cannot completely reproduce your example. If I use the respective pyramid oereb branch setting in pyramid_oereb.yml

    # Flag to print or not the municipality name
    # print_municipality_name: true

or


    # Flag to print or not the municipality name
    print_municipality_name: true
``
no municipality name is printed. Do you know why?
peterschaer commented 1 year ago

I observe the same behaviour as @michmuel does. I can't get the municipality name to be printed.

jwkaltz commented 1 year ago

Indeed I forgot something, sorry. I will do a new commit.

marionb commented 1 year ago

@michmuel and @peterschaer can you test again it should be working with the last commit.

marionb commented 1 year ago

@michmuel do you want to also review? Or is it OK for you to merge this?

michmuel commented 1 year ago

@marionb It is good for me as Peter has tested it and approved. Many thanks.