openoms / joininbox

A terminal based graphical menu for JoinMarket
MIT License
153 stars 20 forks source link

YG menu - misleading option names #154

Open oPFGKk9gtuw8nuHkzrQn opened 3 months ago

oPFGKk9gtuw8nuHkzrQn commented 3 months ago

There are two options in this menu which produce a result that does not always correspond to what the name suggests.

Options

When running joininbox, having the order book activated and running Yield Generator, there are two log files always updated: One logfile for the orderbook and one for the actual Yield Generator.

There are two issues:

  1. When "View the last YG file (debug)" is chosen, the LATEST log file is opened, which means, it can be either the orderbook logfile or the yieldgenerator logfile - it depends on which file had been changed most recently. I therefore suggest to rename the option to : View the latest logfile. However, it would be nice to actually always choose the YG log and not the one that only shows entries for the orderbook.

  2. "Show the last used counterparty name" actually refers to the orderbook or at least it often does. Perhaps it is a similar problem to issue 1: It sometimes does not have anything to do with name of the YG offer. If a name is given there, then it is the name of the bot that creates the orderbook. It would be nicer to acutally see the name of the current offer, so one can look it up in the orderbook.

Finally: The second issue actually is interconncted with the first issue. Solving number 2 could also help solve number 1. If somehow coininbox can identify the YG name of the current offer, then issue 1 can be solved, since coininbox can now always present the actual log that is created due to the YG offer by looking up [YG name].log. And consequently, it is "YG name" that should be presented as "last used counterpartyname".

oPFGKk9gtuw8nuHkzrQn commented 3 months ago

I am sorry if this is confusing: I think the problem only persists when YG is used and also the orderbook is running, since coininbox always chooses the latest logfile which can be either from the orderbook or from the actual YG.