openoms / joininbox

A terminal based graphical menu for JoinMarket
MIT License
153 stars 20 forks source link

Commented lines in joinmarket.cfg #69

Closed frennkie closed 2 years ago

frennkie commented 2 years ago

I changed this

# default ports are 8332 for mainnet, 18443 for regtest, 18332 for testnet, 38332 for signet
rpc_port = 8332

into this

# default ports are 8332 for mainnet, 18443 for regtest, 18332 for testnet, 38332 for signet
#rpc_port = 8332
rpc_port = 38332

Due to the way you are extracting the values with awk: https://github.com/openoms/joininbox/blob/47c4e8136896d693289bad01dd681a634bd1fcf9/scripts/_functions.bitcoincore.sh#L264 this doesn't work - as it does not ignore the comment line (with "#" at the beginning). Instead of 38332 it tries the curl connect to "localhost:8332 38332" - which times out.

I removed the additional line and made the change on the one existing line. But a config format that is a bit more robust would be nice