search

openoms / joininbox

A terminal based graphical menu for JoinMarket
MIT License
153 stars 20 forks source link

Allow setting specific python version #73

Closed tehelsper closed 2 years ago

tehelsper commented 2 years ago

By setting the JM_PYTHON env variable prior to installing joininbox, you can choose the python version used by JoinMarket.

This is required for myNode, which has users still running arm32 operating systems. JoinMarket cannot currently run on python 3.8 with arm32. Controlling the python version is a short-term workaround.

openoms commented 2 years ago

This could be automatically set on 32bit ARM machines where:

$ uname -m
armv7l

I have a 32bit Odroid XU4 running and can confirm it has Python 3.7.3.

The question is if we should we make sure python 3.7 is installed in case it is a new 32bit deployment?

tehelsper commented 2 years ago

Yeah, that's why I made it configurable, but you could check for arm32 and that python3.7 exists. I basically do that on myNode, but I didn't want to assume all other distros had python 3.7 specifically. I was going to leave it up to the user to choose what they wanted.

This could also be used if someone just happened to have multiple versions of python3 and wanted to use a specific one or test a new version or something.

openoms commented 2 years ago

Ok thanks, will work with this. Merging.