openoms / joininbox

A terminal based graphical menu for JoinMarket
MIT License
153 stars 20 forks source link

QR code for connecting to the JM wallet daemon #78

Closed Fonta1n3 closed 2 years ago

Fonta1n3 commented 2 years ago

Hello 👋 ,

I have finally got JM working well with FN via the new rpc api. It would be amazing if Joininbox could support the connection method. Here is what is needed:

Please let me know if you need any other info or have any questions, it would be great to have a place where I can recommend users easily connect FN to JM.

As a side note FN allows users to create tor auth keys, if they had the ability to add their pubkey to joininbox the connection would become much more secure than only relying on the self signed cert and onion.

Thanks for all that you do!

openoms commented 2 years ago

So this will need the joinmarket daemon running with a service as in: https://github.com/rootzoll/raspiblitz/blob/6d3af0cd8c79129d838cc91063e56c9d8c458ad7/home.admin/config.scripts/bonus.joinmarket-webui.sh#L134

Regarding the Tor auth keys there is a guide here which can be implemented: https://github.com/openoms/bitcoin-tutorials/blob/master/tor_hidden_service_example.md#add-client-authorization-optional

Question: how the Tor auth key would be shared? Should show an other QRcode and copy paste to Fully Noded or is there a more automated option to scan it in directly? Is there a format preferred or just the key as a simple string?

Fonta1n3 commented 2 years ago

Question: how the Tor auth key would be shared?

FN creates the private key locally encrypts, saves it and allows you to either refresh your private key and/or export the public key in plain text and QR as a simple string.

Should show an other QRcode and copy paste to Fully Noded or is there a more automated option to scan it in directly?

FN does not allow the importing of tor auth private keys bc the tor recommended security practice states the client should create and hold the private key.

However it would be a simple change to allow the importing of the private key to FN and I'm open to making that change incase users want to create their own auth keys. It would be via QR scan or paste.

Is there a format preferred or just the key as a simple string?

Simple string as of now. The full descriptor with key. descriptor:x25519:GSXUEQF46K6YEHOVCGD6NKLN5ZXDWX2SUIRIAGFKJ26KHYBHDYOA

openoms commented 2 years ago

The option to connect Fully Noded with a QRcode now is in the TOOLS menu.

Can be tested by updating to the latest commit in the master branch with menu -> UPDATE -> ADVANCED -> JBCOMMIT. Then see the TOOLS menu to connect.

openoms commented 2 years ago

closing as no reports of problems will included in the next release